-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENVS] Envs updates #63
Open
samuelmyoussef
wants to merge
100
commits into
SofaDefrost:main
Choose a base branch
from
samuelmyoussef:envs_updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecrease max angle allowed
…ofaDefrost#62) * change abstract class to no server * add server class * modify viewer * modify simulate & goal initializtion * simulation init and reset * remove unneeded goal and reward update and unused reward update param * add general methods to init and randomize states and goal * no server * class instantiation * remove unused goal components * add some default configs * initialize states * Update pole angle from position directly instead of calculation and decrease max angle allowed * goal init * remove non-overriden methods * separate AbstractEnv and ServerEnv into two files
alxbilger
approved these changes
Oct 18, 2024
Hi @samuelmyoussef, would you have the time to solve the conflicts? |
Yes, I can do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the environments based on the no-server implementation #62